Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The internal code from Metadata service is shown under Top Level namespace in docs #3952

Closed
4 tasks done
trivikr opened this issue Nov 10, 2021 · 2 comments · Fixed by #3954
Closed
4 tasks done

The internal code from Metadata service is shown under Top Level namespace in docs #3952

trivikr opened this issue Nov 10, 2021 · 2 comments · Fixed by #3954
Labels
bug This issue is a bug.

Comments

@trivikr
Copy link
Member

trivikr commented Nov 10, 2021

Confirm by changing [ ] to [x] below to ensure that it's a bug:

Describe the bug
The Metadata service Endpoints are shown under Top Level namespace in docs.

Is the issue in the browser/Node.js?
Docs

If on Node.js, are you running this on AWS Lambda?
N/A

Details of the browser/Node.js version
N/A

SDK version number
N/A

To Reproduce (observed behavior)
View Top Level namespace in the docs.

Expected behavior
The internal code used by Metadata Service should either be published under MetadataService namespace, or it shouldn't be published at all.

Screenshots

Screenshot

Screen Shot 2021-11-10 at 9 58 06 AM

@trivikr trivikr added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. and removed needs-triage This issue or PR still needs to be triaged. labels Nov 10, 2021
@trivikr
Copy link
Member Author

trivikr commented Nov 10, 2021

This happens as anything with module {} gets added to top level workspace.
We will move internal code used by metadata_service under namespace AWS.MetadataService.

@trivikr
Copy link
Member Author

trivikr commented Nov 10, 2021

Experimental PR was posted at #3953
A quick solution appears to be moving all source code under metadata_service.js just like other files which contain all the source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
1 participant