Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline comments break SharedCredentials parsing #837

Closed
miketheman opened this issue Jun 5, 2015 · 3 comments
Closed

Inline comments break SharedCredentials parsing #837

miketheman opened this issue Jun 5, 2015 · 3 comments

Comments

@miketheman
Copy link
Contributor

Took me an hour to figure this out.

Repro:
Use this ini mock:

[default] # this is my default
aws_access_key_id = ACCESS_KEY_0 
aws_secret_access_key = SECRET_KEY_0
aws_session_token = TOKEN_0

The resulting credentials will no longer have a default.

awscli handles this correctly, the ini_parse method currently does not.

@trevorrowe
Copy link
Member

Thank you for reporting this issue. I'll take a look at this shortly.

@trevorrowe
Copy link
Member

Thank you for reporting this. The fix will go out with the next release.

@miketheman
Copy link
Contributor Author

👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants