Open tracing support?

[tosheer]

Are you guys planing to adhere to open tracing specification?

[haotianw465]

Hi, please see a response here: https://forums.aws.amazon.com/thread.jspa?threadID=272498&tstart=0
Will leave this issue open for a while for gathering more feedback from community.

[tosheer]

@haotianw465 Thanks mate. I have added more details on the forum question opened by me.

[ashleymercer]

@haotianw465 I've actually started building an xray-opentracing bridge internally for my current company, and I have a couple of questions:

• I'd be interested in open-sourcing this, and my company is supportive - would there be interest from you or from the community for this?

• if I do open-source, am I okay to refer to Amazon, AWS etc? I don't want to infringe on any copyright, and am very happy to make clear that I'm not affiliated with you guys in any way (other than being a very happy customer!)

Thanks

[awssandra]

Hi Ashley,

We're 100% supportive of any and all open-source projects! In fact, we have a few collaborations going on at the moment. If you would want any input from our end we are happy to help.

You can refer to our collaboration with Cookpad here: https://github.com/cookpad/aws-xray

If you'd like and are open to it, we would be happy to host it under our AWS Labs project.

[dmytro-bekuzarov]

Hey guys.
Can someone give the latest updates on the topic?
In particular, I am looking for either for java x-ray sdk compatible with AWS Java SDK v2 (which I suppose is not there yet) or for x-ray implementation of OpenTracing API in java (unofficial or whatever).
Wondering if it's even possible conceptually.
Willing to contribute, just don't want to start from scratch.

[ashleymercer]

Hi Dmytro :)

java x-ray sdk compatible with AWS Java SDK v2 (which I suppose is not there yet)

Actually, it looks like they got around to adding X-Ray support to the SDK v2 in the last few weeks. I haven't tried it yet, but if you upgrade to version 2.2.1 of the Java SDK you should be set:

https://github.com/aws/aws-xray-sdk-java/blob/master/CHANGELOG.md

or for x-ray implementation of OpenTracing API in java (unofficial or whatever).
Wondering if it's even possible conceptually.

Actually, it is - although there are few inconsistencies in the API that you have to work around. As I mentioned above, we have a basic working version at my company except (a) it's currently written in Scala, so would need to be reworked in Java and (b) I haven't had time to open source it yet - but hopefully soon and will report back on this thread when it's done :)

Hope that helps,

Ashley

---

EDIT: I've created an (as-yet, empty) repo for this work, hopefully should have something in the next week or two:

https://github.com/ashleymercer/opentracing-java-aws-xray

[dmytro-bekuzarov]

Actually, it looks like they got around to adding X-Ray support to the SDK v2 in the last few weeks. I haven't tried it yet, but if you upgrade to version 2.2.1 of the Java SDK you should be set:
I tried, but it still relies on AWS SDK v1.x. Having an issue with it, posted here: #56

https://github.com/ashleymercer/opentracing-java-aws-xray
Waiting for updates 👍

[ashleymercer]

Okay, after some back-and-forth with my company we've agreed to host this under a company organization on github. The first version of the code is here:

https://github.com/skylight-ipv/opentracing-java-aws-xray

@dmytro-bekuzarov if you get a chance, would you be able to try it out? I'm still figuring out signing and deployment to maven repos, so you'll need to build from scratch with maven 3.6.0 or higher.

@awssandra @haotianw465 would you be able to give the code an initial once-over? I think my broad approach is correct (just wrap the underlying AWSXRayRecorder and related classes in the OpenTracing API) but it might be better to provide a deeper integration?

[ashleymercer]

Update: this has now moved to live under the opentracing-contrib project:
https://github.com/opentracing-contrib/java-xray-tracer

[ashleymercer]

Just to keep this issue up to date: there is a move to unite two previous projects (OpenTracing, mentioned here, and a similar project called Open Census).

The combined, unified API will be called OpenTelemetry and the goal is to have the spec nailed down by the end of this year, I believe.

@tosheer @haotianw465 I'd like to propose updating this issue to "Native OpenTelemetry support".

[ss2305]

@ashleymercer We are exploring solutions to ensure cross standard compatibility. Just out of curiosity, will you be contributing to the OpenTelemetry project emitters/bridges to work with X-Ray ?

[ashleymercer]

@ss2305 that would be awesome! Are you happy / able to update this existing issue, or is it worth creating a new one? Presumably this would be a new version (v3?) of the X-Ray libraries?

I'm not currently involved in OpenTelemetry directly, although I am on various mailing lists so trying to keep up with what's going on! If there are specific projects / repos you think I could help with, please point me in the right direction and I'll try to help where I can.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[willarmiros]

The X-Ray SDK has been implemented with the OpenTelemetry API standard in a new repo. It will continue to be updated as the OpenTelemetry team updates their API specification. Note that both the API specification, and with it our implementation, are in early, experimental stages. Please raise any issues with our integration on that repository. Thank you!