Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary Guava dependency #39

Closed
Sandmania opened this issue Nov 7, 2018 · 2 comments
Closed

Remove unnecessary Guava dependency #39

Sandmania opened this issue Nov 7, 2018 · 2 comments
Labels

Comments

@Sandmania
Copy link

In commit Support CS in Java com.google.guava:guava:25.1-jre was added as a dependency to aws-xray-recorder-sdk-core/pom.xml. To the best of my knowledge this is not used anywhere (all tests pass without it) and unnecessarily bloats up modules that depend on aws-xray-recorder-sdk-core. This can have adverse performance impacts in places like lambda deployments.

For the time being, I've manually excluded the dependency like so:

        <dependency>
            <groupId>com.amazonaws</groupId>
            <artifactId>aws-xray-recorder-sdk-aws-sdk</artifactId>
            <version>2.0.1</version>
            <exclusions>
                <exclusion>
                    <groupId>com.google.guava</groupId>
                    <artifactId>guava</artifactId>
                </exclusion>
            </exclusions>
        </dependency>
        <dependency>
            <groupId>com.amazonaws</groupId>
            <artifactId>aws-xray-recorder-sdk-aws-sdk-instrumentor</artifactId>
            <version>2.0.1</version>
        </dependency>

X-Ray instrumentation seems to work as expected even without guava. Please let me know if excluding this dependency might lead into some unwanted results.

@haotianw465
Copy link
Contributor

You are right. This dependency is unnecessary and we will remove it in our next release.

@haotianw465 haotianw465 added the bug label Nov 8, 2018
@haotianw465
Copy link
Contributor

This issue is fixed as part of 2.1.0 release. See CHANGELOG for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants