Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

future dependency should be scoped to python 2 in setup.py #212

Closed
kapilt opened this issue Apr 3, 2020 · 1 comment · Fixed by #343
Closed

future dependency should be scoped to python 2 in setup.py #212

kapilt opened this issue Apr 3, 2020 · 1 comment · Fixed by #343

Comments

@kapilt
Copy link
Contributor

kapilt commented Apr 3, 2020

currently there's an unconditional dep on the future library but afaics its just compatibility to python3, ideally that should be detected in the handful of places its used to avoid the shim/alias on python3. afaics there's only two uses

./aws_xray_sdk/core/plugins/ec2_plugin.py
2:from future.standard_library import install_aliases

./aws_xray_sdk/ext/sqlalchemy/util/decorators.py
4:from future.standard_library import install_aliases

@stale
Copy link

stale bot commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs in next 7 days. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants