Global cors #1276
Merged
Global cors #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1276 +/- ##
==========================================
+ Coverage 96.19% 96.19% +<.01%
==========================================
Files 28 28
Lines 5285 5288 +3
Branches 674 675 +1
==========================================
+ Hits 5084 5087 +3
Misses 130 130
Partials 71 71
Continue to review full report at Codecov.
|
stealthycoin
force-pushed
the
global-cors
branch
from
d92181b
to
ed33818
Compare
jamesls
approved these changes
Oct 22, 2019
docs/source/api.rst
Outdated
|
|
||
| Global cors configuration. If a route-level cors configuration is not | ||
| provided, or is ``None`` then this configuration will be used. By | ||
| defualt it is set to ``False``. This can either be ``True``, ``False``, |
stealthycoin
force-pushed
the
global-cors
branch
from
ed33818
to
1093bd1
Compare
CORS config can now be set globally and overriden by a route's `cors` argument. Routes that do not explicitly set a cors parameter, or provide `None` will use the global CORS config.
stealthycoin
force-pushed
the
global-cors
branch
from
1093bd1
to
4cf69d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We missed a feature in closing #70 the global enabling of CORS.