Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of escaping on RHEL License username/password breaks image-builder #1782

Open
raykrueger opened this issue Jan 24, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@raykrueger
Copy link
Contributor

What happened:

Building a rhel image with image-builder will break if the rhel license password contains special characters like $ or !
An image build will fail with a misleading message about a missing variable.

2023/01/24 16:48:31 Initiating Image Build
 Image OS: redhat
 Hypervisor: vsphere
2023/01/24 16:48:31 Executing command: /usr/bin/bash -c make -C /home/image-builder/eks-anywhere-build-tooling/projects/kubernetes-sigs/image-builder local-build-ova-rhel-8
make: Entering directory '/home/image-builder/eks-anywhere-build-tooling/projects/kubernetes-sigs/image-builder'
source /home/image-builder/eks-anywhere-build-tooling/build/lib/common.sh && retry git clone https://github.com/kubernetes-sigs/image-builder.git image-builder
Makefile:20: warning: undefined variable '9'

What you expected to happen:
Expected a successful build.

How to reproduce it (as minimally and precisely as possible):
Create a rhel license user with a $ in the passowrd.
Create a vsphere-connection.json with that password in place.
Build a rhel ova using image-builder

Anything else we need to know?:

Environment:

  • EKS Anywhere Release:
  • EKS Distro Release:
@raykrueger raykrueger added the bug Something isn't working label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant