Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow eksctl to generate TinkerbellTemplateConfig #3588

Closed
Cajga opened this issue Oct 6, 2022 · 11 comments · Fixed by #6436
Closed

Allow eksctl to generate TinkerbellTemplateConfig #3588

Cajga opened this issue Oct 6, 2022 · 11 comments · Fixed by #6436
Assignees
Labels
area/providers Generic provider development external An issue, bug or feature request filed from outside the AWS org priority/p2 Backlog item triage/accepted
Milestone

Comments

@Cajga
Copy link
Contributor

Cajga commented Oct 6, 2022

What would you like to be added: It would be really helpful if we could generate a TinkerbellTemplateConfig and be able to edit that. Or to have an option for eksctl anywhere generate clusterconfig $CLUSTER_NAME --provider tinkerbell to include TinkerbellTemplateConfig into the generated clusterconfig yaml.

Why is this needed: As discussed in multiple bottlerocket os issues (first, second ) it is extremely likely that eno1 will not be the network interface name of the metal server but this is hard-coded into the current template. As such, we have to include TinkerbellTemplateConfig(s) in most of the cases.

However, the documentation includes an old example. The images listed there are outdated compared to what is really generated at cluster create.
In documentation the stream image action is using:
https://anywhere-assets.eks.amazonaws.com/releases/bundles/11/artifacts/raw/1-22/bottlerocket-v1.22.10-eks-d-1-22-8-eks-a-11-amd64.img.gz
But latest version of eks-anywhere is using:
https://anywhere-assets.eks.amazonaws.com/releases/bundles/18/artifacts/raw/1-23/bottlerocket-v1.23.9-eks-d-1-23-5-eks-a-18-amd64.img.gz

As a workaround, I've created a cluster and copied the template from $CLUSTER_NAME/generated/$CLUSTER_NAME-eks-a-cluster.yaml and edited that, then recreated the cluster with the proper template. But this is very inconvenient.

@zmrow
Copy link
Contributor

zmrow commented Oct 6, 2022

Relating #3411 for additional context. :)

@vincentni vincentni added the external An issue, bug or feature request filed from outside the AWS org label Oct 7, 2022
@vincentni
Copy link
Member

Thank you for reaching out to us! Forward your request to our internal team for discussions.

@gwesterfieldjr
Copy link
Contributor

@Cajga we can do this. I'm adding it to our backlog.

@drewvanstone drewvanstone added triage/accepted area/providers Generic provider development priority/p2 Backlog item labels Nov 10, 2022
@github-actions
Copy link

There has been no activity on this issue for 60 days. Labeling as stale and closing in 7 days if no further activity.

@github-actions github-actions bot added the stale label Jan 10, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2023
@Cajga
Copy link
Contributor Author

Cajga commented Jan 18, 2023

Although the default is more flexible now, this would be still very useful to have.
We are planning to use bonding for networking (we are on baremetal) as well as dedicated network catds for storage. As such we have to modify the templates.

@github-actions
Copy link

There has been no activity on this issue for 60 days. Labeling as stale and closing in 7 days if no further activity.

@github-actions github-actions bot added the stale label Mar 25, 2023
@Cajga
Copy link
Contributor Author

Cajga commented Mar 27, 2023

Just reiterating to keep this issue live: for bare metal users this would be a huge help as we need to use TinkerbellTemplateConfig in many real life use cases (dedicated network card for storage, bonding, use different interface for network than the one which was determined etc.)

@github-actions
Copy link

There has been no activity on this issue for 60 days. Labeling as stale and closing in 7 days if no further activity.

@github-actions github-actions bot added the stale label May 28, 2023
@Cajga
Copy link
Contributor Author

Cajga commented May 28, 2023

/remove stale

@github-actions github-actions bot removed the stale label May 29, 2023
@github-actions
Copy link

There has been no activity on this issue for 60 days. Labeling as stale and closing in 7 days if no further activity.

@github-actions github-actions bot added the stale label Jul 29, 2023
@Cajga
Copy link
Contributor Author

Cajga commented Jul 29, 2023

/remove stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/providers Generic provider development external An issue, bug or feature request filed from outside the AWS org priority/p2 Backlog item triage/accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants