Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dotnet/roslyn): analyzer target framework #1071

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

RomainMuller
Copy link
Contributor

The Roslyn analyzer target framework must be set to netstandard2.0 or
it will not successfully load up in Visual Studio.

Fixes aws/aws-cdk#5189


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The Roslyn analyzer target framework must be set to `netstandard2.0` or
it will not successfully load up in Visual Studio.

Fixes aws/aws-cdk#5189
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Nov 26, 2019

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot merged commit fea0f0a into master Nov 26, 2019
@mergify mergify bot deleted the rmuller/fix-roslyn-analyzer branch November 26, 2019 17:08
@mergify mergify bot removed the ready-to-merge label Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An instance of analyzer Amazon.JSII.Analyzers.JsiiOptionalAnalyzer cannot be created
3 participants