fix(rosetta): "Rosetta configured for live conversion to undefined" #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An incorrect update to optional chaining changed the criteria for the target overlap test in Rosetta live conversions and triggered the error in the regular case instead of only in cases where restricts have to be enforced. Reverted to the previous syntax with achieves the correct result.
skinny85
approved these changes
Dec 13, 2019
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An incorrect update to optional chaining changed the criteria for the
target overlap test in Rosetta live conversions and triggered the error
in the regular case instead of only in cases where restricts have to be
enforced.
Reverted to the previous syntax with achieves the correct result.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.