fix(jsii): missing context on "Message" diagnostics #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainMuller
added
effort/small
MrArnoldPalmer
approved these changes
Feb 27, 2020
The context (source file with wiggly lines) was not shown for diagnostics using the `Message` category. This removes the special case so that context is always rendered, which ensures a better experience overall.
RomainMuller
force-pushed
the
rmuller/always-show-context
branch
from
8d49456 to
2ad6e83
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context (source file with wiggly lines) was not shown for
diagnostics using the
Messagecategory. This removes the specialcase so that context is always rendered, which ensures a better
experience overall.
Fixes #1174
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.