Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): improve metadata of jsii package #1587

Merged
merged 2 commits into from
Apr 20, 2020
Merged

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Apr 20, 2020

Commit Message

feat(python): improve metadata of jsii package (#1587)

Add references to the GitHub repository, etc... in order to improve the
detail page experience on https://pypi.org/project/jsii/. Interestingly,
we already produce some of these metadata entries (where relevant) in
the packages generated by jsii-pacmak but failed to include those in
the runtime library's package descriptor.

End Commit Message


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Add references to the GitHub repository, etc... in order to improve the
detail page experience on https://pypi.org/project/jsii/. Interestingly,
we already produce some of these metadata entries (where relevant) in
the packages generated by `jsii-pacmak` but failed to include our own.
@RomainMuller RomainMuller added the effort/small Small work item – less than a day of effort label Apr 20, 2020
@RomainMuller RomainMuller requested a review from a team April 20, 2020 12:34
@RomainMuller RomainMuller self-assigned this Apr 20, 2020
@mergify mergify bot added contribution/core This is a PR that came from AWS. labels Apr 20, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
  • Commit ID: 3738839
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
  • Commit ID: 4f01804
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2020

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Apr 20, 2020
@mergify mergify bot merged commit 7dd04fe into master Apr 20, 2020
@mergify mergify bot deleted the rmuller/pypi-metadata branch April 20, 2020 13:21
@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2020

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants