Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsii): document location of initializers in source #1806

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

RomainMuller
Copy link
Contributor

Those were previously not recorded, although the assembly schema supports
recording this information.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Those were previously not recorded, although the assembly schema supports
recording this information.
@RomainMuller RomainMuller requested a review from a team July 21, 2020 13:53
@RomainMuller RomainMuller self-assigned this Jul 21, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 21, 2020
@RomainMuller RomainMuller added effort/small Small work item – less than a day of effort module/compiler Issues affecting the JSII compiler labels Jul 21, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
  • Commit ID: d7390a8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2020

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Jul 21, 2020
@mergify mergify bot merged commit 3957827 into master Jul 21, 2020
@mergify mergify bot deleted the rmuller/locaiton-of-constructors branch July 21, 2020 14:16
@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2020

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Jul 21, 2020
@iliapolo iliapolo mentioned this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort module/compiler Issues affecting the JSII compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants