feat(java): use covariant types for collection elements #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using covariant expressions instead of just the type name enables a better experience when using libraries such as Guava to build up collections (`List` or `Map`) to use with the libraries. In particular, collections of `any` are particularly annoying to use without covariant typing because they'd force the user to manually specify generic parameters in their code that add nothing to the safety of the program. Fixes #1517
NetaNir
approved these changes
Aug 20, 2020
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using covariant expressions instead of just the type name enables a
better experience when using libraries such as Guava to build up
collections (
ListorMap) to use with the libraries. In particular,collections of
anyare particularly annoying to use without covarianttyping because they'd force the user to manually specify generic
parameters in their code that add nothing to the safety of the program.
Fixes #1517
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.