feat(python): allow setting additional trove classifiers #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the `jsii.targets.python.classifiers` property in `package.json` to an array of strings will trigger insertion of those values in the `classifiers` of the generated python package. Classifiers are de-duplicated and normalized in `setup.py`. Some classifiers prefixes are considered "managed" (an appropriate value is automatically determined for those based on the package's metadata), and while configuring those will not cause `jsii-pacmak` to fail, a warning will be emitted as manually specifying any of those is usually a Bad Idea™: - `Development Status ::` - `License ::` - `Operating System ::` - `Typing ::` Existing (i.e: valid) trove classifiers are mastered in the [`trove-classifiers`](https://github.com/pypa/trove-classifiers) PyPA package. This contributes to aws/cdk-ops#393
RomainMuller
added
language/python
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the
jsii.targets.python.classifiersproperty inpackage.jsonto an array of strings will trigger insertion of those values in the
classifiersof the generated python package.Classifiers are de-duplicated and normalized in
setup.py. Someclassifiers prefixes are considered "managed" (an appropriate value is
automatically determined for those based on the package's metadata), and
while configuring those will not cause
jsii-pacmakto fail, a warningwill be emitted as manually specifying any of those is usually a
Bad Idea™:
Development Status ::License ::Operating System ::Typing ::Existing (i.e: valid) trove classifiers are mastered in the
trove-classifiersPyPApackage.
This contributes to aws/cdk-ops#393
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.