feat(go): embed jsii runtime application #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundles the `@jsii/runtime` application within the go runtime library. This ships the necessary files as byte slices in `embeddedruntime.generated.go`. The `client` initializer will un-pack this into a temporary directory (cleaned up by `client.Close()`) and run that, unless the user specified the `JSII_RUNTIME` environment variable (in which case, that command is used instead). The `client` also assigns `JSII_AGENT` to a string representing the `go` stack version used during build (`runtime.Version()`), the operating system under which the application is running and the CPU architecture. The string is formatted as `VERSION/OS/ARCH`. A new `runtime.go` was introduced that manages a singleton `client` instance and exports a `Close` function that can be invoked to gracefully clean up the child process.
RomainMuller
added
language/go
This was referenced Oct 1, 2020
SoManyHs
approved these changes
Oct 2, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundles the
@jsii/runtimeapplication within the go runtime library.This ships the necessary files as byte slices in
embeddedruntime.generated.go. Theclientinitializer will un-packthis into a temporary directory (cleaned up by
client.Close()) and runthat, unless the user specified the
JSII_RUNTIMEenvironment variable(in which case, that command is used instead).
The
clientalso assignsJSII_AGENTto a string representing thegostack version used during build (
runtime.Version()), the operatingsystem under which the application is running and the CPU architecture.
The string is formatted as
VERSION/OS/ARCH.A new
runtime.gowas introduced that manages a singletonclientinstance and exports a
Closefunction that can be invoked togracefully clean up the child process.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.