fix(pacmak/python): escape character escapes in python docs #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
jsteinich
commented
Oct 18, 2020
jsteinich
changed the title
jsteinich
commented
Oct 19, 2020
Comment on lines
116
to
126
| test('escape character escaping', () => { | ||
| converts( | ||
| [ | ||
| `For example, if you specify \\N, BigQuery interprets \\N as a null value`, | ||
| ], | ||
| [ | ||
| `For example, if you specify \\\\N, BigQuery interprets \\\\N as a null value`, | ||
| ], | ||
| ); | ||
| }); | ||
|
|
There was a problem hiding this comment.
This omits to test for the "must not escape" case.
Co-authored-by: Romain Marcadier <romain.muller@telecomnancy.net>
RomainMuller
previously approved these changes
Oct 22, 2020
mergify
bot
dismissed
RomainMuller’s stale review
Pull request has been modified.
RomainMuller
approved these changes
Oct 22, 2020
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2137
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.