feat(go): extension & overrides mechanism #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces object (re)allocations and makes the code a little more efficient. Nothing groud-breaking through.
# Conflicts: # packages/@jsii/go-runtime/jsii-runtime-go/internal/typeregistry/registration.go # packages/@jsii/go-runtime/jsii-runtime-go/internal/typeregistry/typeregistry.go # packages/@jsii/go-runtime/jsii-runtime-go/runtime.go # packages/jsii-pacmak/test/generated-code/__snapshots__/target-go.test.ts.snap
# Conflicts: # packages/@jsii/go-runtime-test/project/compliance_test.go # packages/@jsii/go-runtime/jsii-runtime-go/internal/typeregistry/registration.go # packages/@jsii/go-runtime/jsii-runtime-go/runtime.go # packages/jsii-pacmak/test/generated-code/__snapshots__/target-go.test.ts.snap
RomainMuller
added
language/go
eladb
reviewed
Mar 17, 2021
iliapolo
approved these changes
Mar 18, 2021
# Conflicts: # packages/@jsii/go-runtime-test/project/compliance_test.go # packages/@jsii/go-runtime/jsii-runtime-go/internal/kernel/conversions.go # packages/jsii-pacmak/test/generated-code/__snapshots__/target-go.test.ts.snap
RomainMuller
removed
the
pr/do-not-merge
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
# Conflicts: # gh-pages/content/specification/6-compliance-report.md # packages/@jsii/go-runtime-test/project/compliance_test.go # packages/jsii-pacmak/lib/targets/go/runtime/class-constructor.ts # packages/jsii-pacmak/test/generated-code/__snapshots__/examples.test.ts.snap # packages/jsii-pacmak/test/generated-code/__snapshots__/target-go.test.ts.snap
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements and documents a mechanism for supporting class
extension and overrides in go, where such concepts are not endemic.
This uses a new "overriding" constructor generated for open classes,
and a special tag users should use to specify which members are
overridden on the base type.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.