-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deprecated symbol stripping does not strip out heritage clause with imported type #2783
Conversation
…ith imported type When a non-deprecated class or interface inherits a deprecated class or interface, the `--strip-deprecated` option does not strip out the heritage clause. This particularly affects cases where the inherited class or interface is non-local, i.e., imported from another file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing test
Testing
|
8791c8e
to
6049a91
Compare
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Merging (with squash)... |
Merging (with squash)... |
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
Merging (with squash)... |
When a non-deprecated class or interface inherits a deprecated class or
interface, the
--strip-deprecated
option does not strip out theheritage clause.
This particularly affects cases where the inherited class or interface
is non-local, i.e., imported from another file.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.