Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent construction of data types and constructs #279

Closed
fulghum opened this issue Oct 24, 2018 · 3 comments
Closed

Inconsistent construction of data types and constructs #279

fulghum opened this issue Oct 24, 2018 · 3 comments
Assignees
@bmaizels
Labels
language/java Related to Java bindings needs-discussion This issue/PR requires more discussion with community. p0

Comments

@fulghum
Copy link

fulghum commented Oct 24, 2018

Data type classes versus Construct classes have inconsistent experience for creation.
ex: CodeProperty – have to guess whether to call new or builder pattern. Inconsistent and confusing.

(might be more of a CDK codebase issue than a jsii issue..)
@fulghum fulghum added the language/java Related to Java bindings label Oct 24, 2018
@RomainMuller RomainMuller added this to the Java Support milestone Jul 30, 2019
@fulghum
Copy link
Author

fulghum commented Aug 13, 2019

@RomainMuller and @bmaizels – does the switch to builders address any of this feedback that we received? Any thoughts on this one?

@fulghum fulghum added p0 needs-discussion This issue/PR requires more discussion with community. labels Aug 13, 2019
@bmaizels
Copy link
Contributor

I think this is covered by other tasks (switching to builders and create)

@RomainMuller
Copy link
Contributor

Resolving in favor of #488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmaizels bmaizels

Labels
language/java Related to Java bindings needs-discussion This issue/PR requires more discussion with community. p0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fulghum @RomainMuller @bmaizels