fix(rosetta): literal map type is rendered as __object in C sharp #3047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`declare` statements are an ideal way to signify that you expect certain variables of certain types to already exist. Add support for them to Rosetta.
The error was in conflating "detecting a map type but not knowing what the element type was" and "not detecting a map type" (these cases could not be distinguished because both would result in `undefined`). Also remove an unnecessary argument to `keyValueObjectLiteralExpression`. Fixes #3026.
eladb
approved these changes
Oct 11, 2021
| @@ -0,0 +1,4 @@ | |||
| Map<String, Object> expected = Map.of( | |||
| "Foo", "Bar", | |||
There was a problem hiding this comment.
Is this the desired indentation?
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
rix0rrr
changed the title
|
Merging (with squash)... |
1 similar comment
|
Merging (with squash)... |
|
Merging (with squash)... |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(The diff of this PR will clean up after #3044 has been merged)
The error was in conflating "detecting a map type but not knowing
what the element type was" and "not detecting a map type" (these
cases could not be distinguished because both would result in
undefined).Also remove an unnecessary argument to
keyValueObjectLiteralExpression.Fixes #3026, fixes #3027.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.