fix(rosetta): breaks when given a lot of snippets #3075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rosetta started breaking recently (the process just exiting witout any error), presumably because we increased the number of compiling code snippets and hitting some undocumented limit in the worker message API. Upon closer inspection the `ts.Diagnostic` objects we were sending over the wire from the worker to the main process were holding on to a `ts.SourceFile` object, and by extension to the entire parse tree and internal TypeScript objects. Instead, introduce a new type of object (`RosettaDiagnostic`) which is a simple data holder with a couple of fields, and render the original TypeScript diagnostics down to these and send these over the wire. This should improve memory usage, and appears to make the rosetta process finish again.
| if (diagnostics.length > 0) { | ||
| printDiagnostics(diagnostics, process.stderr); | ||
| // eslint-disable-next-line prettier/prettier | ||
| logging.error(`${diagnostics.length} diagnostics encountered in ${snippetCount} snippets (running with '--fail')`); |
There was a problem hiding this comment.
I guess this is minor, but given that we hardcoded true in the call to renderResult, is it always true that the user ran the script with --fail?
otaviomacedo
approved these changes
Oct 18, 2021
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rosetta started breaking recently (the process just exiting witout any error),
presumably because we increased the number of compiling code snippets and
hitting some undocumented limit in the worker message API.
Upon closer inspection the
ts.Diagnosticobjects we were sending over thewire from the worker to the main process were holding on to a
ts.SourceFileobject, and by extension to the entire parse tree and internal TypeScript
objects.
Instead, introduce a new type of object (
RosettaDiagnostic) which isa simple data holder with a couple of fields, and render the original
TypeScript diagnostics down to these and send these over the wire.
This should improve memory usage, and appears to make the rosetta
process finish again.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.