feat(jsii): allow customizing tsconfig.json file name #3076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support environment in which users want to use the default name tsconfig.json for a different compiler configuration (e.g. configuration that includes both sources and test files), add a switch to the jsii compiler that allows customizing the name of the generated tsconfig.json file.
Chriscbr
reviewed
Oct 18, 2021
There was a problem hiding this comment.
I'm not sure I fully understand the use-case, in particular, that scenario sounds like we might be building a footgun... As it becomes all too easy for people to cause the .js files that'll end up packaged up (by jsii-packmak) to have been transformed with a configuration that is incompatible with the runtimes.
eladb
commented
Oct 19, 2021
added 3 commits
October 19, 2021 11:02
RomainMuller
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support environment in which users want to use the default name tsconfig.json for a different compiler configuration (e.g. configuration that includes both sources and test files), add a switch to the jsii compiler that allows customizing the name of the generated tsconfig.json file.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.