feat(pacmak): fail on untranslated snippets #3127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of backwards compatibility reasons, pacmak will try to live-translate example code it encounters. However, this can add unpredictably to the compile times, especially while we're making sure that rosetta and pacmak agree on API locations for all snippets that are being translated (which are now part of the snippet keys). Add an option to pacmak to fail if any snippets are encountered that are not pre-translated in any of the tablets. This most likely signifies an error. This will be enabled in cdklabs/cdk-ops#1777.
kaizencc
approved these changes
Nov 5, 2021
| rosetta.translateSnippet(SAMPLE_CODE, TargetLanguage.PYTHON); | ||
| }).toThrow(/snippet was not found/); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Should we test UnknownSnippetMode.VERBATIM as well?
Co-authored-by: kaizen3031593 <36202692+kaizen3031593@users.noreply.github.com>
Co-authored-by: kaizen3031593 <36202692+kaizen3031593@users.noreply.github.com>
…s/jsii into huijbers/pacmak-fail-untranslated
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
Merging (with squash)... |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of backwards compatibility reasons, pacmak will try to live-translate
example code it encounters. However, this can add unpredictably to the compile
times, especially while we're making sure that rosetta and pacmak agree on API
locations for all snippets that are being translated (which are now part of the
snippet keys).
Add an option to pacmak to fail if any snippets are encountered that are not
pre-translated in any of the tablets. This most likely signifies an error.
This will be enabled in cdklabs/cdk-ops#1777.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.