Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pacmak): remove disclaimer on compiling examples #3148

Merged
merged 3 commits into from
Nov 9, 2021

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Nov 9, 2021

We're pretty confident in our rosetta translations by now. If we
successfully compiled the example, no need to prefix it with
a disclaimer anymore: the translation is most likely correct.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

We're pretty confident in our rosetta translations by now. If we
successfully compiled the example, no need to prefix it with
a disclaimer anymore: the translation is most likely correct.
@rix0rrr rix0rrr requested a review from a team November 9, 2021 17:28
@rix0rrr rix0rrr self-assigned this Nov 9, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 9, 2021
Copy link
Contributor

@otaviomacedo otaviomacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a way to measure this, by the way?

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Nov 9, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Merging (with squash)...

Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Merging (with squash)...

@mergify mergify bot merged commit 75e4093 into main Nov 9, 2021
@mergify mergify bot deleted the huijbers/remove-disclaimer branch November 9, 2021 22:39
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants