fix(jsii): constants can't mix letters and digits #3209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An enum identifier like `C5A` is not possible: the `case` library we use to assert casing will insist you change it to `C5_A`. Bypass this rule for constant-like values: do a more lenient validation of our own. Fixes #3208.
njlynch
approved these changes
Nov 26, 2021
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
This was referenced Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An enum identifier like
C5Ais not possible: thecaselibrary we useto assert casing will insist you change it to
C5_A.Bypass this rule for constant-like values: do a more lenient validation
of our own.
Fixes #3208.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.