feat: specify output directory for assemblies #3437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows passing an option `outdir` option to `transliterateAssembly` command. This allows users to generate transliterated assemblies without polluting the package directory if so desired. Enables fixing of cdklabs/jsii-docgen#390
Chriscbr
approved these changes
Mar 22, 2022
MrArnoldPalmer
added a commit
to cdklabs/jsii-docgen
that referenced
this pull request
Mar 22, 2022
Removes copy of the project directory and instead only outputs transliterated assemblies to the working directory. This avoids potential problems when generating docs for packages that may have some dependencies hoisted. IE when building against `aws-cdk-lib` within `node_modules` and `constructs` is hoisted to the top level `node_modules` directory as well. Pending aws/jsii#3437 fixes #390
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows passing an option
outdiroption totransliterateAssemblycommand. This allows users to generate transliterated assemblies without
polluting the package directory if so desired.
Enables fixing of cdklabs/jsii-docgen#390
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.