feat(java): utility to perform unsafe cast #3730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an `UnsafeCast.unsafeCast` method to the Jsii runtime for Java that allows unsafely casting an instance to a managed interface of the user's choice. This can be useful when dealing with type unions composed of interfaces or structs, as there is otherwise no way to convert the instance without jumping through hoops. Fixes #3726 (sort of)
iliapolo
reviewed
Aug 30, 2022
| } | ||
| } | ||
|
|
||
| private UnsafeCast(){ |
There was a problem hiding this comment.
Why leftovers?
A missing condition in the code generator could have resulted in attempting to read a property on undefined, resulting in a crash.
A missing condition in the code generator could have resulted in attempting to read a property on undefined, resulting in a crash.
iliapolo
approved these changes
Aug 30, 2022
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
UnsafeCast.unsafeCastmethod to the Jsii runtime for Java thatallows unsafely casting an instance to a managed interface of the user's
choice.
This can be useful when dealing with type unions composed of interfaces
or structs, as there is otherwise no way to convert the instance without
jumping through hoops.
Fixes #3726 (sort of)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.