fix: pip, black, setuptools, twine, wheel, and aws-sam-cli incorrectly installed in superchain #4201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y installed in superchain The packages were installed in a virtual environment, which is not subsequently re-activated in the image's ENTRYPOINT. Instead, install the packages 'globally'
TheRealAmazonKendra
approved these changes
Aug 2, 2023
RomainMuller
force-pushed
the
rmuller/no-venv-in-dockerfile-build
branch
2 times, most recently
from
2d84593
to
eb6317c
Compare
RomainMuller
added a commit
that referenced
this pull request
Aug 2, 2023
…y installed in superchain (#4201) The packages were installed in a virtual environment, which is not subsequently re-activated in the image's ENTRYPOINT. Instead, install the packages 'globally'
rix0rrr
added a commit
that referenced
this pull request
Aug 10, 2023
In #4201, we introduced a Python distribution built with `pyenv` in order to safely install some Python packages globally. However, using pyenv drives the build time of the images up from 30m to 3 hours. This PR switches back to the distro Python and installs `pipx` to do global installs of Python packages. `pipx` will give each tool its own venv (similar to how `npm install -g` would work).
mergify bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
In #4201, we introduced a Python distribution built with `pyenv` in order to safely install some Python packages globally. However, using pyenv drives the build time of the images up from 30m to 3 hours. This PR switches back to the distro Python and installs `pipx` to do global installs of Python packages. `pipx` will give each tool its own venv (similar to how `npm install -g` would work). --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The packages were installed in a virtual environment, which is not subsequently re-activated in the image's ENTRYPOINT. Instead, install the packages 'globally'
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.