fix(jsii-diff): catch exception if type disappeared from other assembly #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make jsii-diff not crash in the following case: - Assembly A depends on Assembly B, and they both update simultaneously. - Assembly A' uses a return type T' freshly introduced in Assembly B'. When doing the supertype check, the compatibility check of A -> A', the lookup of T' inside B would lead to an exception, which would crash the tool.
|
Not tested because adding tests on this is hard |
RomainMuller
approved these changes
May 21, 2019
RomainMuller
added a commit
that referenced
this pull request
May 21, 2019
### Bug Fixes * **assembler:** handle unknown types without crashing ([#501](#501)) ([7ba1aab](7ba1aab)) * **jsii:** deduplicate interfaces ([#497](#497)) ([05f5189](05f5189)), closes [#496](#496) * **jsii-diff:** catch exception if type disappeared from other assembly ([#504](#504)) ([8d11900](8d11900)) * **jsii-diff:** correctly handle assignability of type unions ([#500](#500)) ([04c061e](04c061e)) * **jsii-diff:** don't fail on new packages ([#502](#502)) ([d1d0633](d1d0633)) ### Features * **jsii:** protect against prohibited member names ([#506](#506)) ([2848f76](2848f76)) ### BREAKING CHANGES * **jsii:** The `equals` and `hashCode` method names may no longer be used on JSII classes and interfaces, due to their colliding with "special meaning" methods in other languages (Java, .NET, ...).
Merged
RomainMuller
added a commit
that referenced
this pull request
May 21, 2019
### Bug Fixes * **assembler:** handle unknown types without crashing ([#501](#501)) ([7ba1aab](7ba1aab)) * **jsii:** deduplicate interfaces ([#497](#497)) ([05f5189](05f5189)), closes [#496](#496) * **jsii-diff:** catch exception if type disappeared from other assembly ([#504](#504)) ([8d11900](8d11900)) * **jsii-diff:** correctly handle assignability of type unions ([#500](#500)) ([04c061e](04c061e)) * **jsii-diff:** don't fail on new packages ([#502](#502)) ([d1d0633](d1d0633)) ### Features * **jsii:** protect against prohibited member names ([#506](#506)) ([2848f76](2848f76)) ### BREAKING CHANGES * **jsii:** The `equals` and `hashCode` method names may no longer be used on JSII classes and interfaces, due to their colliding with "special meaning" methods in other languages (Java, .NET, ...).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make jsii-diff not crash in the following case:
When doing the supertype check, the compatibility check of A -> A',
the lookup of T' inside B would lead to an exception, which would
crash the tool.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.