fix(kernel): properly deserialize structs passed in byref #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deserializer mistakingly used `objectReference` instead of `isObjRef` when trying to identify this case. Test was added to verify this fix. Fixes #553 Co-authored-by: Romain Muller <rmuller@amazon.com>
ghost
requested a review
from 
shivlaks
approved these changes
Jun 25, 2019
|
I'm not positive this is the right fix. Don't merge yet please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deserializer mistakingly used
objectReferenceinstead ofisObjRefwhen trying to identify this case.Test was added to verify this fix.
Fixes #553
Co-authored-by: Romain Muller rmuller@amazon.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.