feat: add in termination check for nodes without machines #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4568460215
💛 - Coveralls |
ellistarn
previously approved these changes
Mar 28, 2023
njtran
force-pushed
the
terminationcheck
branch
from
a7ef719
to
f507efb
Compare
3 tasks
njtran
added a commit
to njtran/karpenter
that referenced
this pull request
Apr 18, 2023
…-sigs#252) * feat: add in termination check for nodes without machines * reorganize code * change controller requeue logic * fix ci test flake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes aws/karpenter-provider-aws#3562
Description
Adds in a termination check to see if the underlying instance is not found. If not found, Karpenter will delete the node and remove the finalizer.
How was this change tested?
make presubmitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.