Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added expiration as node annotation for monitorability #266

Merged
merged 4 commits into from
Apr 4, 2023
Merged

feat: added expiration as node annotation for monitorability #266

merged 4 commits into from
Apr 4, 2023

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Apr 3, 2023

Fixes #

Description
This changes expiration to annotate the node so that users can be aware of when an expired node is queued up for deprovisioning.

How was this change tested?
make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner April 3, 2023 20:27
@njtran njtran requested a review from ellistarn April 3, 2023 20:27
@coveralls
Copy link

coveralls commented Apr 3, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4612908510

  • 54 of 61 (88.52%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 81.109%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/deprovisioning/expiration.go 6 7 85.71%
pkg/controllers/node/drift.go 13 16 81.25%
pkg/utils/node/node.go 7 10 70.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/deprovisioning/expiration.go 1 74.51%
Totals Coverage Status
Change from base Build 4611316530: 0.2%
Covered Lines: 6629
Relevant Lines: 8173
💛 - Coveralls

jonathan-innis
jonathan-innis previously approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 , couple nits

pkg/controllers/node/expiration.go Show resolved Hide resolved
pkg/controllers/node/drift.go Show resolved Hide resolved
jonathan-innis
jonathan-innis approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran merged commit 959b537 into kubernetes-sigs:main Apr 4, 2023
@njtran njtran deleted the annotateExpiry branch April 13, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellistarn ellistarn ellistarn left review comments

@jonathan-innis jonathan-innis jonathan-innis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@njtran @coveralls @ellistarn @jonathan-innis