Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add eventing for blocked consolidation on nodes or machines #303

Merged
merged 1 commit into from
May 2, 2023
Merged

chore: Add eventing for blocked consolidation on nodes or machines #303

merged 1 commit into from
May 2, 2023

Conversation

jonathan-innis
Copy link
Member

Fixes #

Description

  • Add additional eventing for reasons that we remove Machine/Node combinations out of our filtering when considering consolidation

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner April 27, 2023 23:33
@coveralls
Copy link

coveralls commented Apr 27, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4866195575

  • 9 of 18 (50.0%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 81.901%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/deprovisioning/types.go 3 12 25.0%
Files with Coverage Reduction New Missed Lines %
pkg/scheduling/requirements.go 2 98.5%
Totals Coverage Status
Change from base Build 4865802766: 0.003%
Covered Lines: 6824
Relevant Lines: 8332
💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the blocked-eventing branch 2 times, most recently from 457a69c to 025bf04 Compare May 2, 2023 22:03
njtran
njtran previously approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonathan-innis jonathan-innis merged commit ab2d168 into kubernetes-sigs:main May 2, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzneal tzneal tzneal left review comments

@ellistarn ellistarn ellistarn left review comments

@njtran njtran njtran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonathan-innis @coveralls @tzneal @ellistarn @njtran