fix: Gate nodes associated with a machine based on resolved .status.providerID
#346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Prior to this change, in the release
v0.28.0-rc.1
, if a Machine failed to launch, the.status.providerID
of the machine could possibly not be resolved. If this was the case, the Machine would eventually get deleted due to a timeout on registration, causing any nodes associated with the machine to also be removed.In this case, we were not guarding against the case where the providerID has never been resolved, meaning that we were deleting all nodes that had an empty providerID, meaning that Karpenter would delete nodes that weren't managed by it.
This change guards this case so that the next release
v0.28.0-rc.2
will not terminate these nodes when machines with empty provider ids are removed.How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.