chore: rewrite machine controller names

[guikcd]

Fix: #3741
EDIT: only machine related controller names changed.

Description

Rename controller names to respect the codebase structure.
I've not changed pkg/controllers/metrics/state/controller.go which has name metric_scraper, please confirm me that this specific name can be changed to metrics.state and have no impact on the rest of the Karpenter project.

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[jackfrancis]

This might be a great change, but I'm not sure it would classify as a fix? Seems like something that may have breaking side-effects and so we'd want to ensure it's only rolled out in a minor release and called out in release notes.

[guikcd]

This might be a great change, but I'm not sure it would classify as a fix? Seems like something that may have breaking side-effects and so we'd want to ensure it's only rolled out in a minor release and called out in release notes.

You're right, a chore is probably more appropriate, ✔️

[coveralls]

Pull Request Test Coverage Report for Build 5091393148

• 2 of 3 (66.67%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.1%) to 81.443%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/controllers/machine/garbagecollection/controller.go	0	1	0.0%

Totals
Change from base Build 5074239499:	0.1%
Covered Lines:	6921
Relevant Lines:	8498

---

💛 - Coveralls

[jonathan-innis]

have no impact on the rest of the Karpenter project

This has impact on metrics controller name labels so it technically classifies as breaking, but I think that this change makes sense.

[jonathan-innis]

Looking over the whole codebase, it probably makes sense to scope like this based on the directory structure:

• consistency
• counter
• deprovisioning
• machine.garbagecollection
• machine.lifecycle
• machine.termination
• metrics.pod
• metrics.provisioner
• metrics.state
• node
• provisioning
• provisioning.trigger
• state.daemonset
• state.machine
• state.node
• state.pod
• state.provisioner

[jonathan-innis]

LGTM 🚀 Made some comments on additional changes that you can do to make controller names consistent throughout!

[guikcd]

LGTM 🚀 Made some comments on additional changes that you can do to make controller names consistent throughout!

✅

[tzneal]

The machine changes look ok since they haven't been released, but I don't think we can change the others without some significant discussion and possibly linking it to v1beta1. It would silently break anyone that is using these for alarming.

[guikcd]

The machine changes look ok since they haven't been released, but I don't think we can change the others without some significant discussion and possibly linking it to v1beta1. It would silently break anyone that is using these for alarming.

Make totally sense. PR updated to only modify machine controller names ✅

[jonathan-innis]

It would silently break anyone that is using these for alarmin

Makes sense @tzneal. We can rope this into the metrics/observability discussion.

[jonathan-innis]

@guikcd Would you mind making the same changes to machine controllers in the aws/karpenter repo?

[jonathan-innis]

LGTM 🚀

[guikcd]

@guikcd Would you mind making the same changes to machine controllers in the aws/karpenter repo?

aws/karpenter-provider-aws#3945

[tzneal]

lgtm