fix: Fix support for --cloudprovider=external
#375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-innis
changed the title
jonathan-innis
force-pushed
the
fix-1.26-taints
branch
from
2bf96dd
to
8e67296
Compare
jonathan-innis
changed the title
--cloudprovider=external
njtran
approved these changes
Jun 20, 2023
jonathan-innis
changed the title
--cloudprovider=external--cloudprovider=external
ellistarn
pushed a commit
to ellistarn/karpenter
that referenced
this pull request
Jun 22, 2023
ellistarn
pushed a commit
to ellistarn/karpenter
that referenced
this pull request
Jun 22, 2023
ellistarn
pushed a commit
to ellistarn/karpenter
that referenced
this pull request
Jun 22, 2023
ellistarn
added a commit
that referenced
this pull request
Jun 22, 2023
3 tasks
|
Is it known if this bug impacts all releases prior to 0.28.0? For example, 0.27.5. I ask, because the issue is defined as being introduced by an external change in EKS 1.26 |
|
Prior to v0.28, Karpenter created the node object. In that case, kubelet wouldn't add the taint so the problem only existed in v0.28.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
EKS 1.26 adds in the support for
--cloudprovider=external. Adding this value to the kubelet arguments causes the kubelet registration process to register the Node with thenode.cloudprovider.kubernetes.io/uninitialized. Karpenter was unaware of this change, which caused it to overlaunch capacity when these taints were added to the node on startup.How was this change tested?
Saw Karpenter over-scale when running a version prior to this change. After upgrade to the snapshot version that included this change, Karpenter did not over-scale and went to the proper number of nodes.
Prior to this change
With this change
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.