-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add karpenter.sh/registered
label
#397
Merged
jonathan-innis
merged 1 commit into
kubernetes-sigs:main
from
jonathan-innis:node-registration-label
Jul 14, 2023
Merged
chore: Add karpenter.sh/registered
label
#397
jonathan-innis
merged 1 commit into
kubernetes-sigs:main
from
jonathan-innis:node-registration-label
Jul 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-innis
force-pushed
the
node-registration-label
branch
from
July 3, 2023 22:24
9886181
to
15e60cd
Compare
jonathan-innis
changed the title
Add
chore: Add Jul 3, 2023
karpenter.sh/registered
labelkarpenter.sh/registered
label
jonathan-innis
force-pushed
the
node-registration-label
branch
2 times, most recently
from
July 3, 2023 22:36
b533d75
to
72e6775
Compare
Pull Request Test Coverage Report for Build 5448973616
💛 - Coveralls |
Pull Request Test Coverage Report for Build 5556670919
💛 - Coveralls |
jonathan-innis
force-pushed
the
node-registration-label
branch
3 times, most recently
from
July 3, 2023 22:46
8170b6c
to
66249e8
Compare
jonathan-innis
force-pushed
the
node-registration-label
branch
from
July 11, 2023 19:02
66249e8
to
0549e6c
Compare
njtran
previously approved these changes
Jul 14, 2023
jonathan-innis
force-pushed
the
node-registration-label
branch
from
July 14, 2023 16:38
0549e6c
to
a347e41
Compare
jonathan-innis
force-pushed
the
node-registration-label
branch
from
July 14, 2023 17:24
a347e41
to
a51b3c3
Compare
njtran
approved these changes
Jul 14, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
karpenter.sh/registered
label to keep internal data consistency within the Node after all the labels, annotations, and taints have been properly propagated onto the Node after registrationHow was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.