Karpenter should warn upon using likely incorrect labels in NodePools

[tzneal]

Description

What problem are you trying to solve?

Adding a requirement like this to your NodePool will cause nodes to be launched with a random label from this set:

 - key: "eks.amazonaws.com/capacityType"
    operator: In
    values: [ "ON_DEMAND", "SPOT" ]

This should at least produce a warning in the controller as the current behavior can be confusing.

How important is this feature to you?

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[muckelba]

We've stumbled across the same issue. The eks.amazonaws.com/capacityType label is randomly wrong when having it in the karpenter requirements. If it's not in it, its not set at all, so i think using karpenter.sh/capacity-type instead is the best workaround for now.

Is there anything karpenter can do to prevent this issue?