Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix integ test #4779

Merged
merged 3 commits into from
Jul 9, 2024
Merged

fix: fix integ test #4779

merged 3 commits into from
Jul 9, 2024

Conversation

Aditi2424
Copy link
Contributor

Issue #, if available: Fix failing CI health check

Description of changes: Test is failing with the following exception

botocore.exceptions.ClientError: An error occurred (ValidationException) when calling the CreateProcessingJob operation: RoleArn: Cross-account pass role is not allowed.

The input contains a ClusterRoleArn, which we are not able to find the owners for. Temporarily excluding this to unblock pipeline.

Testing done:

export IGNORE_COVERAGE=- ; tox -e py310 -- -s -vv tests/integ/test_processing.py::test_processing_job_inputs_and_output_config ; unset IGNORE_COVERAGE
tests/integ/test_processing.py::test_processing_job_inputs_and_output_config[1.2-1-py3] PASSED

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [ x] I have read the CONTRIBUTING doc
  • [ x] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • [ x] I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Aditi2424 Aditi2424 requested a review from a team as a code owner July 9, 2024 18:45
benieric
benieric previously approved these changes Jul 9, 2024
Copy link
Contributor

@benieric benieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we delete instead of comment even if it is temporary. Also make sure to change PR title to match format like CONTRIBUTING.md since we use the prefix like change:, fix:, etc in release versioning.

@Aditi2424 Aditi2424 changed the title Temporarily remove failing input for integration test fix: fix integ test Jul 9, 2024
@benieric benieric merged commit 502b060 into aws:master Jul 9, 2024
11 checks passed
@Aditi2424 Aditi2424 deleted the ci_integ_fix branch August 21, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants