Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: UserPooldParameter and UserPoolClientIdParameter in backend stack do not update on change #15

Open
lmammino opened this issue Oct 8, 2022 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@lmammino
Copy link
Member

lmammino commented Oct 8, 2022

In backend/serverless.yml we currently define the following parameter:

resources:
  Parameters:
    UserPoolIdParameter:
      Type: AWS::SSM::Parameter::Value<String>
      Default: /weshare/${sls:stage}/userPoolId
    UserPoolClientIdParameter:
      Type: AWS::SSM::Parameter::Value<String>
      Default: /weshare/${sls:stage}/userPoolClientId

These parameters are only populated at the first deployment and are not kept up to date anymore.

If a user redeploys the user pool for any reason, these parameters should change and the backend stack should be able to reference the new values.

This will result in a permanently failed authentication and the inability to upload files.

A possible solution might be to not rely on CloudFormation parameters but use SSM values directly.

A current workaround is to manually update the API Gateway Authorizer for the createShare endpoint and specify there the new values.

@lmammino lmammino added bug Something isn't working help wanted Extra attention is needed labels Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant