-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
please expose "ApproximateArrivalTimestamp" via JsonFriendlyRecord #85
Comments
Thanks for the feedback and the PR. We want to get all of the MultiLanguageDaemon clients up to date with the latest release of the Kinesis Client. We should be able to add the approximateArrivalTimestamp as part of the updates. The PR looks pretty straight forward, and I will look into merging it. This will also require updating the other clients to expose the property as well. |
@pfifer awesome thanks! |
I've merged the PR. I'm looking into adding support for the other languages, but I don't have a timeline on that right now. |
Support for the field is now available, but there are steps required to update the clients. Currently the Python client has been updated to use the new functionality, and we're investigating updating the remainder of the clients. |
I created a issue to track adding the new features to the .NET client. I'm going to close this for now, please feel free to reopen if you have more questions. |
Even though ApproximateArrivalTimestamp is becoming available in Record. However it is not exposed in JsonFriendlyRecord.
This means "ApproximateArrivalTimestamp" is not exposed to anyone who uses KCL and use ProcessRecordsMessage to consume Kinesis Stream. (e.g. .Net developers like me)
The fix is relative simple, and I am happy to provide PR for it.
PS: https://github.com/awslabs/amazon-kinesis-client-net is over a year old, is there any plan on that regards?
The text was updated successfully, but these errors were encountered: