fix(aws-cdk): fix YAML line wrapping issue (#1334)

Fix the issue where incorrect UserData was generated by updating to a newer version of the yaml library. Fixes #1309.
aws · Dec 12, 2018 · 48b9bdd · 48b9bdd
1 parent 3076070
commit 48b9bdd
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/packages/@aws-cdk/applet-js/package.json b/packages/@aws-cdk/applet-js/package.json
@@ -31,7 +31,7 @@
     "@aws-cdk/cdk": "^0.19.0",
     "fs-extra": "^7.0.0",
     "source-map-support": "^0.5.6",
-    "yaml": "^1.0.1"
+    "yaml": "^1.1.0"
   },
   "repository": {
     "url": "https://github.com/awslabs/aws-cdk.git",

diff --git a/packages/aws-cdk/package.json b/packages/aws-cdk/package.json
@@ -63,7 +63,8 @@
     "request": "^2.83.0",
     "semver": "^5.5.0",
     "source-map-support": "^0.5.6",
-    "yaml": "^1.0.1",
+    "table": "^5.1.0",
+    "yaml": "^1.1.0",
     "yargs": "^9.0.1"
   },
   "repository": {

diff --git a/packages/aws-cdk/test/test.yaml.ts b/packages/aws-cdk/test/test.yaml.ts
@@ -1,5 +1,5 @@
 import { Test } from 'nodeunit';
-import { toYAML } from '../lib/serialize';
+import { fromYAML, toYAML } from '../lib/serialize';
 
 // Preferred quote of the YAML library
 const q = '"';
@@ -64,4 +64,18 @@ export = {
 
     test.done();
   },
+
+  'validate emission of very long lines'(test: Test) {
+    const template = {
+      Field: ' very long line that starts with a space. very long line that starts with a space. start on a new line'
+    };
+
+    const output = toYAML(template);
+
+    const parsed = fromYAML(output);
+
+    test.deepEqual(template, parsed);
+
+    test.done();
+  }
 };