fix(aws-autoscaling): Add hook ordering dependency #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an ordering dependency between the LifecycleHook and the role policy that grants permissions to perform the action (publish to a topic or queue). Without this ordering dependency, the template might fail to deploy. Fixes #1212.
eladb
approved these changes
Nov 20, 2018
| * Allow lazy evaluation of a list of dependables | ||
| */ | ||
| export class LazyDependable implements cdk.IDependable { | ||
| constructor(private readonly depList: cdk.IDependable[]) { |
There was a problem hiding this comment.
Accept an IDependable in the ctor instead of a dep list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an ordering dependency between the LifecycleHook and the role policy
that grants permissions to perform the action (publish to a topic or
queue).
Without this ordering dependency, the template might fail to deploy.
Fixes #1212.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.