Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-codebuild): rename the Project methods for adding Actions to CodePipeline #1254

Merged

Conversation

skinny85
Copy link
Contributor

BREAKING CHANGE: this renames the public methods of the Project class,
addBuildToPipeline and addTestToPipeline, to addToPipeline and
addToPipelineAsTest, respectively.

Fixes #1211


Pull Request Checklist

Please check all boxes (including N/A items)

Testing

  • Unit test and/or integration test added
  • Toolkit change?: integration
    tests

    manually executed (paste output to the PR description)
  • Init template change?: coordinated update of integration tests
    (currently maintained in a private repo).

Documentation

  • README: README and/or documentation topic updated
  • jsdocs: All public APIs documented

Title and description

  • Change type: Title is prefixed with change type:
    • fix(module): <title> bug fix (patch)
    • feat(module): <title> feature/capability (minor)
    • chore(module): <title> won't appear in changelog
    • build(module): <title> won't appear in changelog
  • Title format: Title uses lower case and doesn't end with a period
  • Breaking change?: Last paragraph of description is: BREAKING CHANGE: <describe exactly what changed and how to achieve similar behavior + link to documentation/gist/issue if more details are required>
  • References: Indicate issues fixed via: Fixes #xxx or Closes #xxx

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

… CodePipeline.

BREAKING CHANGE: this renames the public methods of the Project class,
`addBuildToPipeline` and `addTestToPipeline`, to `addToPipeline` and
`addToPipelineAsTest`, respectively.
@skinny85 skinny85 requested a review from eladb November 28, 2018 00:41
@eladb
Copy link
Contributor

eladb commented Nov 28, 2018

LGTM.

The phrasing of the "BREAKING CHANGE" paragraph should be read as "what concrete information a user that reads the changelog needs to know". For example:

BREAKING CHANGE: `addBuildToPipeline` was renamed to `addToPipeline` 
and `addTestToPipeline` was renamed to `addPipelineToTest` in order to align 
with naming conventions.

Something like that.

@skinny85 skinny85 merged commit 825e448 into aws:master Nov 28, 2018
@skinny85 skinny85 deleted the feature/unify-add-codebuild-to-pipeline branch November 28, 2018 19:50
@skinny85
Copy link
Contributor Author

LGTM.

The phrasing of the "BREAKING CHANGE" paragraph should be read as "what concrete information a user that reads the changelog needs to know". For example:

BREAKING CHANGE: addBuildToPipeline was renamed to addToPipeline
and addTestToPipeline was renamed to addPipelineToTest in order to align
with naming conventions.

Something like that.

Sure. Changed when merge squashing the commit.

@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codebuild: merge "addBuildToPipeline" and "addTestToPipeline" APIs
3 participants