Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-ecs: doesn't apply healthCheckGracePeriodSeconds #1265

Closed
inoutch opened this issue Nov 30, 2018 · 1 comment · Fixed by #1266
Closed

aws-ecs: doesn't apply healthCheckGracePeriodSeconds #1265

inoutch opened this issue Nov 30, 2018 · 1 comment · Fixed by #1266
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug.

Comments

@inoutch
Copy link

inoutch commented Nov 30, 2018

The BaseServiceProps interface has healthCheckGracePeriodSeconds, but it isn't applied to cloudformation.ServiceResource properties on BaseService constructor.

BaseServiceProps:
https://github.com/awslabs/aws-cdk/blob/72413c12ef5fde720b9d87b844fe70721b8166f4/packages/%40aws-cdk/aws-ecs/lib/base/base-service.ts#L47-L52
In BaseService constructor:
https://github.com/awslabs/aws-cdk/blob/72413c12ef5fde720b9d87b844fe70721b8166f4/packages/%40aws-cdk/aws-ecs/lib/base/base-service.ts#L106-L117
@rix0rrr rix0rrr added bug This issue is a bug. @aws-cdk/aws-ecs Related to Amazon Elastic Container labels Nov 30, 2018
@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 30, 2018

Thanks for the report!

rix0rrr pushed a commit that referenced this issue Nov 30, 2018
fix(aws-ecs): fix healthCheckGracePeriodSeconds
69e4f57 
Respect grace peridos parameter.

Fixes #1265.
@rix0rrr rix0rrr mentioned this issue Nov 30, 2018
Merged
9 tasks
rix0rrr added a commit that referenced this issue Dec 5, 2018
@rix0rrr
fix(aws-ecs): fix healthCheckGracePeriodSeconds (#1266)
3a89e21 
Respect grace peridos parameter.

Fixes #1265.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(aws-ecs): fix healthCheckGracePeriodSeconds aws/aws-cdk
2 participants
@rix0rrr @inoutch