fix(aws-cdk): fix profile use in non-'aws' partitions #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
reviewed
Dec 5, 2018
| @@ -389,6 +406,15 @@ async function hasEc2Credentials() { | |||
| return instance; | |||
| } | |||
|
|
|||
| async function setConfigVariable() { | |||
| const homeDir = process.env.HOME || process.env.USERPROFILE | |||
| || (process.env.HOMEPATH ? ((process.env.HOMEDRIVE || 'C:/') + process.env.HOMEPATH) : null) || os.homedir(); | |||
There was a problem hiding this comment.
Wouldn't os.homedir() just do all of this for you?
There was a problem hiding this comment.
Don't know. This is exactly what the SDK code does, I don't want to risk us going out of sync because there's some environment variable effect somewhere that we haven't considered.
eladb
reviewed
Dec 5, 2018
packages/aws-cdk/lib/api/util/sdk.ts
Outdated
| // Since there is no way to pass a { region } argument to the STS client used for AssumeRole credentials | ||
| // (https://github.com/aws/aws-sdk-js/issues/2377), we must now configure the region globally so that it will | ||
| // be picked up there. | ||
| // AWS.config.update({ |
There was a problem hiding this comment.
Is this not true anymore? I am confused...
There was a problem hiding this comment.
Ah, you're right. This wasn't sufficient. We MUST load the config, and we MUST set the env var to do so. Will remove.
eladb
approved these changes
Dec 5, 2018
|
rix0rrr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly pass on the default region to the STS call we make to discover
the default AWS credentials.
Also, there is no way to make use of AssumeRole profiles without the
AWS_SDK_LOAD_CONFIG flag being set, so reintroduce setting that flag
if we discover the file to exist.
Fixes #1262 and fixes #1109.
Pull Request Checklist
Please check all boxes (including N/A items)
Testing
tests
manually executed (paste output to the PR description)
(currently maintained in a private repo).
Documentation
Title and description
fix(module): <title>bug fix (patch)feat(module): <title>feature/capability (minor)chore(module): <title>won't appear in changelogbuild(module): <title>won't appear in changelogBREAKING CHANGE: <describe exactly what changed and how to achieve similar behavior + link to documentation/gist/issue if more details are required>Fixes #xxxorCloses #xxxBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.