feat(kms): Allow opting out of "Retain" deletion policy #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gives the user control over whether the key should be retained or scheduled for deletion when it is removed from the stack (or the stack is deleted). This is convenient in particular for integration tests, to avoid accumulating garbage over successive runs.
rix0rrr
approved these changes
Feb 6, 2019
eladb
reviewed
Feb 6, 2019
…-key-deletion-policy
…-key-deletion-policy
eladb
approved these changes
Feb 10, 2019
eladb
reviewed
Feb 10, 2019
| @@ -46,7 +46,7 @@ | |||
| "Version": "2012-10-17" | |||
| } | |||
| }, | |||
| "DeletionPolicy": "Retain" | |||
| "DeletionPolicy": "Delete" | |||
| }, | |||
There was a problem hiding this comment.
As a good practice it is usually preferable not to modify existing tests but rather add new tests
There was a problem hiding this comment.
Well... technically I'm only touching here because I want to stop littering the account with one-off keys that we'll never use again... 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives the user control over whether the key should be retained or
scheduled for deletion when it is removed from the stack (or the stack
is deleted). This is convenient in particular for integration tests, to
avoid accumulating garbage over successive runs.
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.