Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk): move apply() from Construct to ConstructNode #1738

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

moofish32
Copy link
Contributor

This change moves the aspect apply() function from the Construct to
the ConstructNode. All other functionality remains the same.

BREAKING CHANGE: Tag aspects use this feature and any consumers of this
implementation must change from myConstruct.apply( ... ) to
myConstruct.node.apply( ... ).

fixes #1732


Pull Request Checklist

  • Testing
    • Unit test added
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

This change moves the aspect `apply()` function from the `Construct` to
the `ConstructNode`. All other functionality remains the same.

BREAKING CHANGE: Tag aspects use this feature and any consumers of this
implementation must change from `myConstruct.apply( ... )` to
`myConstruct.node.apply( ... )`.

fixes aws#1732
@moofish32 moofish32 requested a review from a team as a code owner February 12, 2019 06:45
@eladb eladb merged commit 642c8a6 into aws:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aspects: construct.apply should be construct.node.apply
2 participants