Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): performance improvements #1750

Merged
merged 2 commits into from
Feb 13, 2019
Merged

fix(core): performance improvements #1750

merged 2 commits into from
Feb 13, 2019

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Feb 13, 2019

fix(core): performance improvements

Fix several performance issues:

  • Only prepare the construct tree once.
  • Don't regex-quote a constant string for every Token, do that only
    once.
  • Replace JavaScript object with Map<> for dictionary use.
  • Make sure we don't recurse twice into the arguments of ignoreEmpty during
    rendering of resources.

The latter three bring down synthesis time from ~3.5 seconds to ~1.3s
on an application with 100+ stacks and 6000+ constructs.


Pull Request Checklist

  • Testing
    • Unit test added
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Fix several performance issues:

- Only prepare the construct tree once.
- Don't regex-quote a constant string for every Token, do that only
  once.
- Replace JavaScript object with Map<> for dictionary use.

The latter two bring down synthesis time from ~3.5 seconds to ~1.7s
on an application with 100+ stacks and 6000+ constructs.
@rix0rrr rix0rrr requested a review from a team as a code owner February 13, 2019 13:00
@rix0rrr rix0rrr merged commit 77b516f into master Feb 13, 2019
@rix0rrr rix0rrr deleted the huijbers/perf branch February 13, 2019 14:41
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants